[Xcb] xcb_image_get round trip

Vincent Torri vtorri at univ-evry.fr
Fri Nov 10 00:54:37 PST 2006


Hey,

there's a round trip in xcb_image_get. Shouldn't we change it like:


xcb_image_t *
xcb_image_get (xcb_connection_t *conn,
                constt void      *reply,
 	       uint16_t          width,
 	       uint16_t          height,
 	       uint32_t          plane_mask,
 	       uint8_t           format)
?

That is, the user call xcb_get_image and xcb_get_image_reply before, and 
provide the reply with other necessary data. I don't know if it's 
better that the check of the reply is done by the user or in
xcb_image_get. Afer that, the user will have to free the reply.

Also, maybe we should provide all the *_checked and *_unchecked versions 
of the functions.

Vincent


More information about the Xcb mailing list