[Xcb] Re: Update for RandR 1.2 name changes.

[Barton C Massey]

I guess I've been assuming that the only things that are at
1.0 and thus "sacrosanct" are XCB, Xlib, the XCB core
protocol description, and perhaps some of the most ancient
extensions.  Is this not a viable way to proceed?

	Bart

In message <02BC3F8C-161C-4E30-B919-9888C3A89DCA at quirkster.com> you wrote:
> 
> On Nov 30, 2006, at 5:07 PM, Jamey Sharp wrote:
> 
> > On Thu, Nov 30, 2006 at 12:03:02PM -0800, Ian Osgood wrote:
> >> -  if (setit) xcb_randr_select_input (c, root->root,  
> >> XCB_RANDR_SM_SCREEN_CHANGE_NOTIFY);
> >> +  if (setit) xcb_randr_select_input (c, root->root,  
> >> XCB_RANDR_NOTIFY_MASK_SCREEN_CHANGE);
> >>
> >>    if (setit) {
> >>      xcb_randr_set_screen_config_cookie_t sscc;
> >> @@ -422,7 +422,7 @@ main (int argc, char **argv)
> >>  	       sce->timestamp, sce->config_timestamp);
> >>  	  printf(" Rotation = %x\n", sce->rotation);
> >>  	  printf(" %d X %d pixels, %d X %d mm\n",
> >> -		 sce->width, sce->height, sce->mwidth, sce->mheight);
> >> +		 sce->width, sce->height, sce->mmWidth, sce->mmHeight);
> >
> > Oops, these are API changes. For libxcb, at least, we're committed to
> > not doing that. libxcb-randr is more acceptable to me, but if we can
> > make things work without API changes I'll be happier.
> 
> Oh, boy. I figured only the non-generated code is actually set in  
> stone. I sincerely hope we are not setting the extension and core  
> protocol symbols in stone, because there has never been a review for  
> consistency across extensions, or even within the same extension.   
> Hell, most of the core protocol and extensions haven't ever been tested!
> 
> >
> > Were these changes to the 1.1 portion of the randr spec necessary?
> 
> I will fight for the NOTIFY_MASK change, because it is more  
> consistent with the naming of the core event masks.
> 
> The mwidth/mheight change I don't care as much about, but we should  
> make sure the naming is consistent across all uses of these fields in  
> all randr requests.  (Some of the new requests/events have width/ 
> height in millimeters, and I prefer "mm" to distinguish them, since  
> it is the common abbreviation for millimeter. Also, I mistakenly  
> named the field "mmHeight" expecting it to expand to "mm_height" in  
> the C code. I will go back and substitute underscores for caps.)
> 
> If these are the types of things that will become set in stone, then  
> it is high time for us to review the existing extensions. Consistent  
> naming is very important if you don't want to be vilified by the next  
> 20 years of X programmers.
> 
> Ian
> 
> > --Jamey
> > _______________________________________________
> > Xcb mailing list
> > Xcb at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/xcb
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb