[Xcb] Structure pointers

Jeremy A. Kolb jkolb at brandeis.edu
Thu Oct 12 10:23:35 PDT 2006


We're sending a color type over the wire so you'll be making a copy 
anyway.

Jeremy

On Fri, 13 Oct 2006, Russell Shaw wrote:

> Hi,
> In this prototype (render.c):
> 
> xcb_void_cookie_t
> xcb_render_fill_rectangles (xcb_connection_t      *c,
>                              uint8_t                op,
>                              xcb_render_picture_t   dst,
>                              xcb_render_color_t     color,
>                              uint32_t               rects_len,
>                              const xcb_rectangle_t *rects)
> 
> the parameter: "xcb_render_color_t color" is passing a whole structure
> by value instead of as a pointer. Wouldn't this be more C-like and
> efficient?:
> 
> xcb_void_cookie_t
> xcb_render_fill_rectangles (xcb_connection_t      *c,
>                              uint8_t                op,
>                              xcb_render_picture_t   dst,
>                              xcb_render_color_t     *color,     /* pointer */
>                              uint32_t               rects_len,
>                              const xcb_rectangle_t *rects)
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb
> 



More information about the Xcb mailing list