[Xcb] [PATCH 0/2] xcb: Underscore placement in extension name

[Ian Osgood]

I would argue that extension-oneword should be the default. Of all  
the extensions, I think only xc_misc disobeys this rule (and  
inconsistently; its version constants are named XCB_XCMISC_*). This  
would result in a smaller patchset.

Ian

On Mar 29, 2007, at 12:31 PM, Barton C Massey wrote:

> Eamon,
>
> Thanks hugely---this is a big improvement.  I'll go ahead
> and committed these patches, but let us know if you'd like
> commit privs so you can do this stuff yourself in the
> future.
>
> 	Bart
>
> In message <460BFB61.8020000 at tycho.nsa.gov> you wrote:
>> I'm working on protocol for the XSELinux extension, (extension-name
>> "SELinux") and XCB is putting an underscore in a bad place, like so:
>> xcb_se_linux_query_version_cookie_t
>>
>> I wondered how the XvMC extension got away with not having an
>> underscore, until I found the following in c-client.xsl:
>>
>>    <func:function name="xcb:xcb-prefix">
>>      <xsl:param name="name" />
>>      <func:result>
>>        <xsl:text>xcb</xsl:text>
>>        <xsl:choose>
>>          <xsl:when test="/xcb/@extension-name = 'RandR'">
>>            <xsl:text>_randr</xsl:text>
>>          </xsl:when>
>>          <xsl:when test="/xcb/@extension-name = 'ScreenSaver'">
>>            <xsl:text>_screensaver</xsl:text>
>>          </xsl:when>
>>          <xsl:when test="/xcb/@extension-name = 'XF86Dri'">
>>            <xsl:text>_xf86dri</xsl:text>
>>          </xsl:when>
>>          <xsl:when test="/xcb/@extension-name = 'XFixes'">
>>            <xsl:text>_xfixes</xsl:text>
>>          </xsl:when>
>>          <xsl:when test="/xcb/@extension-name = 'XvMC'">
>>            <xsl:text>_xvmc</xsl:text>
>>          </xsl:when>
>> ...
>>
>> The following patchset introduces a new attribute "extension- 
>> oneword" on
>> the xcb element that triggers this special-case behavior.  Please  
>> apply,
>> I'd like this functionality for the SELinux extension.
>>
>>
>> -- 
>> Eamon Walsh <ewalsh at tycho.nsa.gov>
>> National Security Agency
>> _______________________________________________
>> Xcb mailing list
>> Xcb at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/xcb
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb
>