[Xcb] [patch] bugfix: xproto.xml request GetKeyboardMapping

[Barton C Massey]

Thanks much for the note!  Your scheme stuff is quite cool;
thanks also for the pointer!  (I just want to say for the
record that you could have done it from the M4 also,
though. :-) :-)

I think the encoding given is either right, or only
off-by-one.  The length of the reply in words should be
equal to the number of keysyms in the reply, since keysyms
are 32 bits long---but it looks like the description as
given doesn't take the extra word for keysyms-per-keycode
into account.  At any rate, I like your description better.

Anyone see any reason why we shouldn't apply this patch?

	Bart

In message <87bq9drstd.fsf at ambire.localdomain> you wrote:
> thanks for writing xcb-proto; i like playing w/ it.
> see <http://www.gnuvola.org/data/> for current hackery.
> i think i found a bug, however.  below is the local fix.
> what do you think?
> 
> thi
> 
> 
> _____________________________________________________
> diff --git a/src/xproto.xml b/src/xproto.xml
> index 8254d11..cbddd75 100644
> --- a/src/xproto.xml
> +++ b/src/xproto.xml
> @@ -2015,8 +2015,8 @@ authorization from the authors.
>        <pad bytes="24" />
>        <list type="KEYSYM" name="keysyms">
>          <op op="*">
> -          <fieldref>length</fieldref>
> -          <value>4</value>
> +          <fieldref>count</fieldref>
> +          <fieldref>keysyms_per_keycode</fieldref>
>          </op>
>        </list>
>      </reply>