[Xcb] [PATCH] xv.xml: Make padding explicit

Barton C Massey bart at cs.pdx.edu
Fri Jan 4 18:52:12 PST 2008


These make sense to me--thanks much!  I'll go ahead and
apply them unless someone else here can think of a reason
not to.

	Bart

In message <200801041455.49918.peter.harris at hummingbird.com> you wrote:
> From: Peter Harris <peter.harris at hummingbird.com>
> Subject: [PATCH] xv.xml: Make padding explicit
> 
> ---
> I noticed that xv.xml assumes implicit padding in a couple of locations. 
> Please apply this patch to make the padding explicit. Or is implicit 
> pad support required in all consumers of xcb/proto?
> 
>  src/xv.xml |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/src/xv.xml b/src/xv.xml
> index ebf4837..e5a132f 100644
> --- a/src/xv.xml
> +++ b/src/xv.xml
> @@ -84,11 +84,12 @@ authorization from the authors.
>          <field type="CARD16" name="name_size" />
>          <field type="CARD16" name="width" />
>          <field type="CARD16" name="height" />
> -        <field type="Rational" name="rate" />
>          <!--
> -        Xvproto.h has a padding CARD16 here but the name
> -        overlaps.
> +        Some versions of Xvproto.h incorrectly have
> +        this padding after "rate".
>          -->
> +        <pad bytes="2" />
> +        <field type="Rational" name="rate" />
>          <list type="char" name="name">
>              <fieldref>name_size</fieldref>
>          </list>
> @@ -97,6 +98,7 @@ authorization from the authors.
>      <struct name="Format">
>          <field type="VISUALID" name="visual" />
>          <field type="CARD8" name="depth" />
> +        <pad bytes="3" />
>      </struct>
>  
>      <struct name="Image">
> -- 
> 1.5.3.7
> -- 
>      Hummingbird Connectivity - A Division of Open Text
> Peter Harris                    http://connectivity.hummingbird.com
> Research and Development        Phone: +1 905 762 6001
> peter.harris at hummingbird.com    Toll Free: 1 877 359 4866
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list