[Xcb] SetFontPath specification bug?

[Thien-Thi Nguyen]

Greetings,

I see that proto/src/xproto.xml contains the fragment:

  <request name="SetFontPath" opcode="51">
    <pad bytes="1" />
    <field type="CARD16" name="font_qty" />
    <list type="char" name="path" />
  </request>

  <request name="GetFontPath" opcode="52">
    <reply>
      <pad bytes="1" />
      <field type="CARD16" name="path_len" />
      <pad bytes="22" />
      <list type="STR" name="path">
        <fieldref>path_len</fieldref>
      </list>
    </reply>
  </request>

This shows a discrepency between the "LISTofSTRING8" specification
(as per the X Protocol document PROTO.pdf, page 41, pdf page 45).

Based on the SetFontPath encoding specification from the same document
(page 134, pdf page 138), and also from watching the protocol on the wire
using xset + xmon, I believe the first <request> should be changed to read:

  <request name="SetFontPath" opcode="51">
    <pad bytes="1" />
    <field type="CARD16" name="path_len" />
    <pad bytes="2" />
    <list type="STR" name="path">
      <fieldref>path_len</fieldref>
    </list>
  </request>

Please let me know if i am missing something.

thi