[Xcb] Native win32 port - patches :)

Julien Cristau jcristau at debian.org
Thu May 8 02:06:38 PDT 2008


On Wed, Apr 23, 2008 at 21:37:53 +0530, Jeetu Golani wrote:

> 
> Hi everyone,
> 
> I'm submitting my patches for the win32 port of XCB. I would appreciate if 
> people could look into it and give me feedback....hope it's of use to
> someone :)
> 
Your patches are reversed, can you fix that?  Also, the file
patch_win32_xcb_auth_c in your tarball is itself a tarball and doesn't
contain any change to xcb_auth.c (actually, it would be nicer if you
posted the patches uncompressed).
Please remove the useless "changes for win32" comments.
Please don't mix whitespace changes with your win32 changes.
I'll stop there, because reading reversed patches makes my head hurt.

Cheers,
Julien


More information about the Xcb mailing list