[Xcb] [PATCH] libxcb: Fix multiple xidtype lists in the same request

Peter Harris peter.harris at hummingbird.com
Wed Nov 19 08:23:57 PST 2008

Peter Harris wrote:
> The attached patch fixes a bug where c_client.py wasn't generating
> *_end functions, but expected them to exist in order to find the
> subsequent list's start. I initially hit this bug when working on
> randr: http://lists.freedesktop.org/archives/xcb/2008-November/004037.html
> c_client.py compares field.field_type[0] against a hard-coded list of
> cardinal types. The trouble is, <xidtype>s have a field_type[0] of
> 'xcb'. Just like structures and other non-cardinal types.
> The fix appears to be replacing _cardinal_types with
> field.type.member.is_simple checks.
> The down-side is, after this patch all sorts of *_iterator functions
> go away (and are replaced with *_end functions). I'm not sure if
> anybody is using those functions today, or if we need to provide
> backwards-compatibility.
> Could someone with more knowledge of c_client.py than I have please
> review this patch?

As there have been no further objections in the past week, and since the
patch fixes a real bug: Pushed.

Peter Harris
     Hummingbird Connectivity - A Division of Open Text
Peter Harris                    http://connectivity.hummingbird.com
Research and Development        Phone: +1 905 762 6001
peter.harris at hummingbird.com    Toll Free: 1 877 359 4866

More information about the Xcb mailing list