[Xcb] [PATCH] sync: add missing state in AlarmNotify event

Julien Danjou julien at danjou.info
Thu Sep 4 08:38:27 PDT 2008


At 1220541674 time_t, Peter Harris wrote:
> ALARMSTATE is an enum, and enums don't have a size associated with them.

Indeed, did not think about that.

> I'd love to change that (or at least associate enums with the fields
> they will be used with), but using an enum in place of a type isn't
> currently permitted, AFAIK.
> 
> Should probably be CARD8 for now (possibly with a comment indicating it
> is an ALARMSTATE).

Well, I don't know: it's a typedef-ed enum so I guess it's a integer.
And AFAICT, Xlib does the same (typedef and use it as is).
(and I think Xlib implemented the proto correctly, but I might be
wrong).

Cheers,
-- 
Julien Danjou
// ᐰ <julien at danjou.info>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080904/1e79c353/attachment.pgp 


More information about the Xcb mailing list