[Xcb] Patch for bug 17469

Barton C Massey bart at cs.pdx.edu
Sun Sep 7 23:47:33 PDT 2008

In message <814567.80380.qm at web59910.mail.ac4.yahoo.com> you wrote:
> Hello
> I've attached a patch to this bug (see below) and I
> would like to have a maintainer to look at it. I didn't
> find a specific instructions on how to send patches so I
> just tried to stick with the coding style in the file and
> then I did "git diff > my.patch" (please let me know if it
> needs to me modified or something). The patch is
> contributed under the MIT license.
>   https://bugs.freedesktop.org/show_bug.cgi?id=17469
> Cheers,HS

Thanks much for the patch!  I've pushed it and closed the

Let me be real clear here---we'll take what we can get as
far as patch format etc. :-)  That said, things that will
help us out if you feel so moved:

  * Use git-format-patch to, well, format your patch.  This
    makes it easier for us to apply and warns you about some
    common errors.  (Your patch had some trailing whitespace
    in a comment, which I went ahead and applied because,
    well, I didn't really care that much. :-) I did manually
    set the author information so that you were properly
    credited, but git-format-patch does this automagically.)

  * ASCII emails are much easier for me to work with.

  * Go ahead and email your patch to the list as well as
    submitting to the bug tracking system.  This makes it
    quicker for us to review.

Again, thanks much for the patch!


More information about the Xcb mailing list