[Xcb] [xcb-util/icccm]: last call for comments before commit...
Arnaud Fontaine
arnaud at andesi.org
Fri Sep 12 05:13:34 PDT 2008
>>>>> "Barton" == Barton C Massey <bart at cs.pdx.edu> writes:
Hello,
Barton> * You probably want to put Jamey Sharp's name on the
Barton> icccm copyright list as well; I think he originally wrote
Barton> all of this? In general, I only put the copyright notice of
Barton> the original author on files; I'm not sure that that's
Barton> legally right, though.
Ok, I will.
Barton> * Thanks much for adding the doxygen comments in commit
Barton> ba7f7e1e2149388a8475ffd6bcfda659f5267f83. I'm not so
Barton> excited about the whitespace part of that patch, though....
What do you mean by whitespace? indentation of the code or trailing
whitespaces?
Julien> That seems to be code not used directly in icccm but
Julien> exported with bad names (not xcb_ prefixed). Since I think
Julien> it can be useful, I asked arnau to move it to atoms
Julien> part. It's useful to build atom name like
Julien> _NET_SYSTEM_TRAY_S%d for example.
I also modified the code because it was relying on vasprintf which is a
GNU extension. I hope it's fine like this.
Thank you for your comments.
Cheers,
Arnaud Fontaine
More information about the Xcb
mailing list