[Xcb] Invalid XIDs

Nathaniel Smith njs at pobox.com
Sat Feb 21 15:52:14 PST 2009


On Wed, Feb 18, 2009 at 9:13 AM, Barton C Massey <bart at cs.pdx.edu> wrote:
> -    if(c->xid.last >= c->xid.max - c->xid.inc + 1)
> +    /* XXX the second disjunct asks for a new range if we're
> +       about to return (uint32_t)-1, which would indicate an
> +       error even though no such indication was intended.  I
> +       don't know what else to do here... */
> +    if(c->xid.last >= c->xid.max - c->xid.inc + 1 ||
> +       (c->xid.last + c->xid.inc) | c->xid.base == -1)
>     {
>         xcb_xc_misc_get_xid_range_reply_t *range;
>         assert(c->xid.last == c->xid.max);

Oh, and I believe you were going to drop this?
http://lists.freedesktop.org/archives/xcb/2009-January/004259.html

-- Nathaniel


More information about the Xcb mailing list