[Xcb] Win32 branch of XCB now up :)

[Jeetu Golani]

Hi all,

Peter :
> I sense you've never used git before.

Absolutely :)....sorry for the mess but at least I now know what not to do
;)....any help on doing this would be appreciated....I'm quite new to it.

Julien
>Well your tree does not have the full history of our libxcb, and is only
>a set of file. So this is kinda useless, it is just like throwing a
>tarball at our head.

After cloning your devel tree I explicitly deleted the .git and .gitignore
folders before uploading onto github...thinking it would lead to some sorta
conflict.....I think that's what took off all the orignal history??.....my
bad.

>I cannot judge the code itself, I know nothing at win32, but you should
>at least respect some sort of indentation policy.....

I did - my own which I find easier to read :)....sorry will normalize to the
rest of the code style along with your other suggestions.

>making things in order, since it's win32 code (and I don't care about
>this platform :-)

nor do I :( but *sigh*

Peter
>Thanks for all your effort,

Glad to be able to help

Bye for now

On Wed, May 6, 2009 at 9:56 PM, Julien Danjou <julien at danjou.info> wrote:

> At 1241626325 time_t, Jeetu Golani wrote:
> > I hope these changes can become part of the main tree someday.
>
> Well your tree does not have the full history of our libxcb, and is only
> a set of file. So this is kinda useless, it is just like throwing a
> tarball at our head.
> And your tree is full of backups, .orig and .rej files.
> It's really really far from being clean.
>
> I took some time to make and read diff between your version and ours.
> I cannot judge the code itself, I know nothing at win32, but you should
> at least respect some sort of indentation policy. You seems to have
> none, so using ours would be a good choice.
>
> Also, using:
> #ifdef WIN32
> int read_block() { ... }
> #endif
> #ifndef WIN32
> int read_block() { ... }
> #endif
>
> is IMHO only a way to get confused and make mistakes. Please prefer:
>
> #ifdef WIN32 (or ifndef)
> int read_block() { ... }
> #else
> int read_block() { ... }
> #endif
>
> which can avoid mistakes.
>
> OTOH, your work seems pretty light and not too much invasive, so if you
> come up with a clean patch touching only the code part and the files
> needed, I guess it could be merged into our code base.
>
> But it's far from clean right now and I don't feel like losing time
> making things in order, since it's win32 code (and I don't care about
> this platform :-)
>
> Cheers,
> --
> Julien Danjou
> // ᐰ <julien at danjou.info>   http://julien.danjou.info
> // 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
> // Trust no one.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkoBujAACgkQpGK1HsL+5c3xpwCghwL/RzRGeEs1wi3lPKlanF+u
> OhYAoM7F+1c2D5KEillUqegxdkNMDeaW
> =0sds
> -----END PGP SIGNATURE-----
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/xcb/attachments/20090507/7874d900/attachment.html