[Xcb] Win32 branch of XCB now up :)

[Jeetu Golani]

> _WIN32 is defined by all the Windows compilers (vc++, gcc, ic, ac,
borland, etc...)

hey makes sense :)....will make the changes asap :)


On Tue, May 12, 2009 at 6:53 PM, Vincent Torri <vtorri at univ-evry.fr> wrote:

>
>
> On Tue, 12 May 2009, Jeetu Golani wrote:
>
>
>> Hi Peter,
>>
>> Thanks for getting back :)
>>
>>  1) fprintf(stderr, is not permitted inside libxcb. I know, it's a pain
>>> when error codes get lost, but it's even worse when a library stomps on
>>> the app's output handles.
>>>
>>
>> This worried me too but when I was porting based on one of your earlier
>> releases a grep showed up an fprintf in the file xcb_xlib.c, therefore I
>> thought it was acceptable within the code for some reason and I kept it
>> on. I
>> can't seem to fine xcb_xlib.c in the current release anymore nor any
>> further
>> fprintf statements, so I'll take this off.
>>
>>  2) I prefer #ifdef _WIN32 (defined by the compiler) over #ifdef WIN32
>>> (defined by the makefile). But that's just my personal preference, not
>>> official policy or anything.
>>>
>>
>> I don't mind changing this. Would appreciate if you could explain the
>> rationale behind this from a purely informative perspective.
>>
>
> _WIN32 is defined by all the Windows compilers (vc++, gcc, ic, ac, borland,
> etc...)
>
> Vincent
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/xcb/attachments/20090512/a975b5a9/attachment.htm