[Xcb] Bug#530560: Bug#530560: libxcb-shm0-dev: xcb_shm_completion_event_t mislaid out

Julien Cristau jcristau at debian.org
Tue May 26 01:59:26 PDT 2009


reassign 530560 xcb-proto
tag 530560 confirmed patch upstream
kthxbye

On Mon, May 25, 2009 at 21:44:26 +0300, Remi Denis-Courmont wrote:

> It would seem that the layout of the xcb_shm_completion_event_t
> structure has the segment XID swapped with the event minor/major
> numbers. This breaks processing of SHM completion event pretty badly
> (without an ugly work around).
> 
The following patch against xcb-proto fixes this, thanks for the report!

Cheers,
Julien

From: Julien Cristau <jcristau at debian.org>
Date: Tue, 26 May 2009 10:54:06 +0200
Subject: [PATCH] Fix ShmCompletion event

Reported-by: Remi Denis-Courmont <rdenis at simphalempin.com>
Signed-off-by: Julien Cristau <jcristau at debian.org>
---
 src/shm.xml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/shm.xml b/src/shm.xml
index 7168f3b..adda509 100644
--- a/src/shm.xml
+++ b/src/shm.xml
@@ -34,10 +34,10 @@ authorization from the authors.
   <event name="Completion" number="0">
     <pad bytes="1" />
     <field type="DRAWABLE" name="drawable" />
-    <field type="SEG" name="shmseg" />
     <field type="CARD16" name="minor_event" />
     <field type="BYTE" name="major_event" />
     <pad bytes="1" />
+    <field type="SEG" name="shmseg" />
     <field type="CARD32" name="offset" />
   </event>
 
-- 
1.6.2.4





More information about the Xcb mailing list