[Xcb] Bug#530560: Bug#530560: Bug#530560: libxcb-shm0-dev: xcb_shm_completion_event_t mislaid out

[Julien Cristau]

On Tue, May 26, 2009 at 11:13:28 +0200, Julien Danjou wrote:

> At 1243328366 time_t, Julien Cristau wrote:
> > The following patch against xcb-proto fixes this, thanks for the report!
> 
> Wah. I just pushed a patch which seems different.
> 
> One of us is wrong. I also switch major and minor in my patch, which
> seems in the wrong order compared to XShm.h from Xlib.
> But I did not put the seg after the padding.
> 
> Am I the one with wrong patch?
> 
Yes.  Yours doesn't make sense, you have 1 byte of padding between two
32 bit fields.  See also <X11/extensions/shmstr.h>

typedef struct _ShmCompletion {
    BYTE        type;           /* always eventBase + ShmCompletion */
    BYTE        bpad0;
    CARD16      sequenceNumber B16;
    Drawable    drawable B32;
    CARD16      minorEvent B16;
    BYTE        majorEvent;
    BYTE        bpad1;
    ShmSeg      shmseg B32;
    CARD32      offset B32;
    CARD32      pad0 B32;
    CARD32      pad1 B32;
    CARD32      pad2 B32;
} xShmCompletionEvent;

Please revert your patch and apply the correct one :)

Cheers,
Julien