[Xcb] Predefined atoms

[Julien Danjou]

At 1256888835 time_t, Rémi Denis-Courmont wrote:
> I wouldn't know, but I guess the rationale was to avoid unused static
> warning whenever <xcb_aotm.h> is included. Or does GCC only generate those
> for -non-inline- *functions*? Then perhaps, either an enumeration or a set
> of #define's would be needed.

AFAIK gcc only emits warning for non inline *functions*.

> > Of course, this might mean that we'd want a header
> > auto-generated from these values, and to put the values in
> > the XCB protocol description.
> 
> Yes.
> 
> > Since the default atom values are (AFAIK)
> > part of the protocol description, why are they not in xcb.h
> > instead of off in the atom util library?

They are part of the protocol description. What looks weird is that the
numeric values are not defined in the protocol description however. But
in practice that's not a problem anyway.

So it seems ok to me to move them to xcb.h or some other header provided
by libxcb directly. I'll try to come up with a patch if no one is faster
than me.

-- 
Julien Danjou
// ᐰ <julien at danjou.info>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// There is nothing under this line.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20091105/bffbdc87/attachment.pgp