[Xcb] [PATCH 5/5] GetCrtcGamma: Fix error handling.

Adam Jackson ajax at nwnk.net
Tue Nov 10 06:47:33 PST 2009

On Mon, 2009-11-09 at 17:01 -0800, Jamey Sharp wrote:

> Reviewed-by: Jamey Sharp <jamey at minilop.net>
> I pointed this bug out to Keith last week. XCB-based Xlib assert-fails
> if you try to read past the end of your reply, as this function does
> in the error case, and we got a bug report on the xcb list. I don't
> have a test case for your patch but it looks correct to me.

dispwin(1) from argyllcms would trigger this.  If you had a connected or
unknown-connection output with no associated CRTC, it would attempt to
GetCrtcGamma on the associated CRTC (ie, None).  X would rightly throw
an error, we'd parse it as a reply, assert.  

See also https://bugzilla.redhat.com/show_bug.cgi?id=498931

> I also reviewed the other four patches in this series. Feel free to
> include my Reviewed-by in those as well.


- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/xcb/attachments/20091110/6e54b6ba/attachment.pgp 

More information about the Xcb mailing list