[Xcb] [PATCH] XCBify xlsatoms

Peter Harris git at peter.is-a-geek.org
Wed Nov 11 19:33:47 PST 2009

On Wed, Nov 11, 2009 at 9:04 PM, Jeremy Huddleston wrote:
> I'd rather see these xcb versions have a configure option (--enable-xcb for example)... I'm fine with it being on by default, but it's nice to have a fallback and easy regression testing.

It seems a lot of work for minimal gain. Personally, I would find it
easier to check out the 1.x branch (and/or download the 1.x tarball)
than to pass a magic option to configure. Especially given:

$ wc -l xlsclients.c 0001-xlsclients.patch
     320 xlsclients.c
     690 0001-xlsclients.patch

$ wc -l xlsatoms.c 0001-Convert-xlsatoms-to-XCB.patch
     234 xlsatoms.c
     254 0001-Convert-xlsatoms-to-XCB.patch

These are effectively rewrites. To leave the code in a readable state,
you'd wind up with the Xlib version inside one giant #ifdef, and the
XCB version inside the #else (or vice versa).

If these were larger programs, I'd agree with you. But these are very
small wrappers around basic X protocol operations. There's really very
little (mostly just argument parsing and the copyright notice) that
wasn't Xlib specific inside either of them.

The last time this came up:

Peter Harris

More information about the Xcb mailing list