[Xcb] ConfigureWindow XML change
Barton C Massey
bart at cs.pdx.edu
Wed Oct 21 23:46:41 PDT 2009
Eamon, thanks much for tackling this. I'm not quite sure I
understand your fix :-), but hopefully those affected by it
will.
Bart
In message <4ADF95AA.4010707 at tycho.nsa.gov> you wrote:
> xcb/proto commit 57934c introduced the "value-mask-pad" attribute to fix
> the ConfigureWindow request and it's unique, problematic 2-byte
> value-mask field.
>
> However it was still broken in xpyb (the pad was in the wrong place),
> prompting
> http://bugs.freedesktop.org/show_bug.cgi?id=24507
>
> I was able to fix it harder by reverting 57934c and instead simply
> defining the value-mask-length field early and then the pad bytes:
>
> <request name="ConfigureWindow" opcode="12">
> <pad bytes="1" />
> <field type="WINDOW" name="window" />
> +<field type="CARD16" name="value_mask" />
> +<pad bytes="2" />
> <valueparam value-mask-type="CARD16"
> value-mask-name="value_mask"
> value-list-name="value_list" />
>
> This change shouldn't be a huge deal because defining a length field
> early happens all the time with lists (the Python parser treats
> valueparams as lists which is why this works). But this could in theory
> affect other parsers/bindings, so I wanted to give a heads-up.
>
>
>
> --
> Eamon Walsh<ewalsh at tycho.nsa.gov>
> National Security Agency
>
More information about the Xcb
mailing list