[Xcb] Xfixes xcb problem?

[Julien Cristau]

On Wed, Oct 28, 2009 at 16:13:18 -0400, Peter Harris wrote:

> From: Peter Harris <pharris at opentext.com>
> Date: Wed, 28 Oct 2009 16:05:26 -0400
> Subject: [PATCH] Fix length calculation for xfixes/FetchRegion reply
> 
> Signed-off-by: Peter Harris <pharris at opentext.com>
> ---
>  src/xfixes.xml |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/xfixes.xml b/src/xfixes.xml
> index f6b0623..9bbeaab 100644
> --- a/src/xfixes.xml
> +++ b/src/xfixes.xml
> @@ -229,7 +229,10 @@ authorization from the authors.
>        <field type="RECTANGLE" name="extents" />
>        <pad bytes="16" />
>        <list  type="RECTANGLE" name="rectangles">
> +	<op op='/'>
>  		<fieldref>length</fieldref>
> +		<value>2</value>
> +	</op>
>        </list>
>      </reply>
>    </request>

Looks fine to me: a rectangle is 8 bytes, length is in 4 bytes units...

Also, that matches libXfixes, which does
    nrects = rep.length >> 1;

So FWIW,
Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien