[Xcb] [Bug 23811] xts5 test regression with libxcb-1.3

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 9 12:21:23 PDT 2009


Bart Massey <x at po8.org> changed:

           What    |Removed                     |Added
                 CC|                            |x at po8.org

--- Comment #2 from Bart Massey <x at po8.org>  2009-09-09 12:21:21 PST ---
(In reply to comment #1)
> I wonder if the check for POLLIN [in xcb_conn.c] shouldn't also
> check for POLLHUP/POLLERR. 
> select() returns an fd as readable on EOF, whereas poll(2) says POLLIN means
> "There is data to read."

I'd go further in correcting this code (starting around line 318 in
xcb_conn.c).  It looks to me like in the case where there's an event with
neither POLLIN nor POLLOUT marked, we want to treat this as an error by
default, shut down the connection and return 0.   POLLPRI should be treated as
POLLIN, I think?

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the Xcb mailing list