[Xcb] libxcb won't compile from FreeBSD ports

[Barton C Massey]

The failed patch looks to me like an attempt to work around
a problem we fixed properly some time ago.  I think it
should be discarded.

In general, though, problems with the BSD port system are
sadly outside the purview of this list.

	Bart

In message <4AB4F2A3.2010307 at networktest.com> you wrote:
> FreeBSD 7.2-RELEASE, i386
> 
> Running 'make install clean' from /usr/ports/x11/libxcb returns the
> patch error pasted below.
> 
> Thanks in advance for clues on resolving this. I did not see anything
> helpful in the xcb or freebsd-questions archives or on Google.
> 
> dn
> 
> 
> somehost# cd /usr/ports/x11/libxcb/
> somehost# make clean
> ===>  Cleaning for libxcb-1.4
> somehost# make install clean
> ===>  Vulnerability check disabled, database not found
> ===>  Extracting for libxcb-1.4
> => MD5 Checksum OK for libxcb-1.4.tar.bz2.
> => SHA256 Checksum OK for libxcb-1.4.tar.bz2.
> ===>  Patching for libxcb-1.4
> ===>  Applying FreeBSD patches for libxcb-1.4
> 1 out of 1 hunks failed--saving rejects to src/xcb_auth.c.rej
> => Patch patch-src-xcb_auth.c failed to apply cleanly.
> => Patch(es) patch-Makefile.in applied cleanly.
> *** Error code 1
> 
> Stop in /usr/ports/x11/libxcb.
> 
> 
> And here is /usr/ports/x11/libxcb/work/libxcb-1.4/src/xcb_auth.c.rej:
> 
> ***************
> *** 251,257 ****
> 
>       info->namelen = memdup(&info->name, authptr->name,
> authptr->name_length);
>       if(info->namelen)
> -       ret = compute_auth(info, authptr, sockname);
>       if(!ret)
>       {
>         free(info->name);
> --- 251,262 ----
> 
>       info->namelen = memdup(&info->name, authptr->name,
> authptr->name_length);
>       if(info->namelen)
> +     {
> +         if (getsockname(fd, sockname, &socknamelen) == -1)
> +             ret = 0;
> +         else
> +             ret = compute_auth(info, authptr, sockname);
> +     }
>       if(!ret)
>       {
>         free(info->name);
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb