[Xcb] More pthread stubs.

Jamey Sharp jamey at minilop.net
Mon Apr 12 10:06:35 PDT 2010

Oof, sorry for the delay.

2010/3/10 M Joonas Pihlaja <jpihlaja at cc.helsinki.fi>:
> Just to be clear by "during the build" you mean at autogen time and
> not configure time or later, right?  I've implemented such a solution
> and pushed it to the autogen-stubs branch here:
> http://cgit.freedesktop.org/~joonas/pthread-stubs/log/?h=autogen-stubs
> If this is acceptable I'll go ahead and try to sort out the mutexattr
> problem.

Yes, that looks great. Clearly the list of stubs should be processed
when configure is being generated.

A minor tweak: Would it be alright to stick
m4_syscmd([m4 -P stubs.c.m4 >stubs.c])
in configure.ac, instead of running it in autogen.sh? I personally
prefer to run autoreconf directly rather than relying on autogen.sh
scripts, which seem redundant since autoreconf was introduced. If
there's anyone else like me out there, I'd like to ensure that stubs.c
is still generated.

Either way,
Reviewed-by: Jamey Sharp <jamey at minilop.net>

I've attached the version of the patch I reviewed. If I lose track of
this thread again, after Joonas replies to the above question,
somebody please push this patch. :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: generate-stubs-at-autogen-time.patch
Type: text/x-diff
Size: 11199 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20100412/e946f0e9/attachment.patch>

More information about the Xcb mailing list