[Xcb] [PATCH 2/3] Do not block when calling reply() multiple times.
jamey at minilop.net
Mon Feb 1 17:44:16 PST 2010
On Tuesday, February 2, 2010, Peter Harris <pharris at opentext.com> wrote:
> This feels like duplication of effort to me. XCB already keeps a queue
> of requests that have been issued. It already tracks which replies it
> should discard (ignore) in the future, too.
> Therefore, what do you think of the attached? It adds
> xcb_discard_reply(), which does free(wait_for_reply(cookie, NULL))
> except it doesn't block when the reply hasn't been received yet.
I can't review the patch properly at the moment, but it looks
promising. Does it correctly handle discarding the multiple replies of
a ListFontsWithInfo or similar? Does it work if the request didn't
originally queue a request record, as happens when there are no flags
or workarounds? Assuming the patch is correct, I'd take it.
I still want to see someone try the request queue approach as well,
though, which my intuition says allows for more efficient language
bindings, among other uses. I just can't prove that at the moment. :-)
More information about the Xcb