[Xcb] [PATCH 2/2] Remove constant definition

[Eamon Walsh]

Julien Danjou wrote:

[snip]
> -    /* Basic constants */
> -    PyModule_AddIntConstant(m, "X_PROTOCOL", X_PROTOCOL);
> -    PyModule_AddIntConstant(m, "X_PROTOCOL_REVISION", X_PROTOCOL_REVISION);
> -    PyModule_AddIntConstant(m, "X_TCP_PORT", X_TCP_PORT);
> -    PyModule_AddIntConstant(m, "NONE", XCB_NONE);
> -    PyModule_AddIntConstant(m, "CopyFromParent", XCB_COPY_FROM_PARENT);
> -    PyModule_AddIntConstant(m, "CurrentTime", XCB_CURRENT_TIME);
> -    PyModule_AddIntConstant(m, "NoSymbol", XCB_NO_SYMBOL);
> -

The constants above are defined in xcb.h, not xproto.xml, making them
hard-coded parts of libxcb.  So I think they need to remain hard-coded
in xpyb as well unless there is something I'm missing.  The xproto.xml
file contains an alternate definition of XCB_CURRENT_TIME (in the "Time"
enum), but none of the other constants above are defined there currently.

The atom constants definitely should go and I will push that part of the
patch.

--Eamon W.