[Xcb] [PATCH:xcb-util] Make sure wm_class name strings are null-terminated

Vincent Torri vtorri at univ-evry.fr
Mon Jun 14 08:25:11 PDT 2010

On Mon, 14 Jun 2010, Alan Coopersmith wrote:

> Vincent Torri wrote:
>> On Sun, 13 Jun 2010, Alan Coopersmith wrote:
> I didn't know how widespread use of this is yet, or how painful/acceptable an
> API break would be.   If it is acceptable, then I can work on a patch that
> instead adds instance_name_len & class_name_len to the xcb_get_wm_class_reply_t
> struct.   (Does there need to be an encoding field as well or are wm_class
> properties always in the same encoding?    I don't see a mention of that in
> ICCCM, but I see ICCCM claims WM_CLASS are always null-terminated, when I found
> they weren't always in practice.)
> Since the struct is allocated by the caller, this will cause overflow in
> existing binaries - should the library .so version be bumped?  How is API
> versioning/incompatibility handled?

no versioning or api compatibility have ever been considered in the util/ 
subproject. The API has been broken a *lot* of times. So...


More information about the Xcb mailing list