[Xcb] [RFC PATCH] Delete callback-based APIs for events, properties, and replies.

Mikhail Gusarov dottedmag at dottedmag.net
Thu Jun 24 14:35:35 PDT 2010

Twas brillig at 14:28:21 24.06.2010 UTC-07 when jamey at minilop.net did gyre and gimble:

 >> Shouldn't the xcb_icccm SONAME be bumped here?

 JS> Oh, good point. And xcb_event as well, right? I don't understand the
 JS> rules for SONAME bumps, but I read
 JS> http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

SONAME bumps are easy, libtool versions are complicated :)

 JS> diff --git a/event/Makefile.am b/event/Makefile.am
 JS> index 5a7d819..cec6381 100644
 JS> --- a/event/Makefile.am
 JS> +++ b/event/Makefile.am
 JS> @@ -10,7 +10,7 @@ AM_CFLAGS = $(CWARNFLAGS)
 JS>  libxcb_event_la_SOURCES = event.c
 JS>  libxcb_event_la_CPPFLAGS = $(XCB_CFLAGS)
 JS>  libxcb_event_la_LIBADD = $(XCB_LIBS)
 JS> -libxcb_event_la_LDFLAGS = -version-info 1:0:0
 JS> +libxcb_event_la_LDFLAGS = -version-info 2:0:0
 JS>  pkgconfig_DATA = xcb-event.pc
 JS> diff --git a/icccm/Makefile.am b/icccm/Makefile.am
 JS> index 68059e9..2e7f8ca 100644
 JS> --- a/icccm/Makefile.am
 JS> +++ b/icccm/Makefile.am
 JS> @@ -10,7 +10,7 @@ AM_CFLAGS = $(CWARNFLAGS)
 JS>  libxcb_icccm_la_SOURCES = icccm.c
 JS>  libxcb_icccm_la_CPPFLAGS = $(XCB_CFLAGS) $(XPROTO_CFLAGS)
 JS>  libxcb_icccm_la_LIBADD = $(XCB_LIBS) $(XPROTO_LIBS)
 JS> -libxcb_icccm_la_LDFLAGS = -version-info 2:0:0
 JS> +libxcb_icccm_la_LDFLAGS = -version-info 3:0:0
 JS>  pkgconfig_DATA = xcb-icccm.pc

Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net> as well.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20100625/20ed2b2c/attachment.pgp>

More information about the Xcb mailing list