[Xcb] Problem with dock windows and libxcb-icccm

[David Coppa]

On Wed, Mar 10, 2010 at 9:06 PM, David Coppa <dcoppa at gmail.com> wrote:
> On Wed, 10 Mar 2010, Peter Harris wrote:
>
>> On 2010-03-10 08:18, David Coppa wrote:
>> >
>> > What about this patch?
>>
>> Looks sensible. Could you please include a Signed-off-by in the next
>> version? Thanks.
>>
>> >    if (!(reply->type == XCB_ATOM_WM_SIZE_HINTS &&
>> >          (reply->format == 8  || reply->format == 16 ||
>> > -         reply->format == 32) &&
>> > -        /* OldNumPropSizeElements = 15 (pre-ICCCM) */
>> > -        length >= 15))
>> > +         reply->format == 32)))
>>
>> You could even remove the line "(reply->format == 8  || reply->format ==
>> 16 ||" too, since the size hints must be 32 bit to make sense.
>>
>> Other formats might appear to work if you're not in a mixed-endian
>> environment, but it's safer to just ignore hints with the wrong
>> ->format. Also, the (length >= 15) test is wrong if ->format isn't 32.
>
> Hi Peter,
>
> I've merged your patch at
> http://archive.netbsd.se/view_attachment.php?id=12115870.183264
> with mine.
>
> Is it ok now?

Any news ?

-david-