[Xcb] [PATCH] Delete a useless level of indirection from _xcb_out_send's parameters.

Josh Triplett josh at joshtriplett.org
Sun Mar 28 15:58:28 PDT 2010

On Sun, Mar 28, 2010 at 10:58:16AM -0700, Jamey Sharp wrote:
> _xcb_out_send needs _xcb_conn_wait to store back its progress so it can
> be reinvoked to pick up where it left off---but then _xcb_out_send
> guarantees that it leaves either an empty output vector or a shut-down
> connection, so *its* callers never care how much progress was made.
> Signed-off-by: Jamey Sharp <jamey at minilop.net>
> ---
> Ideally, every patch would be reviewed by somebody. Someone mind
> reviewing this one for me?

I chatted with Jamey for a while to get a good understanding of this
patch.  The result of that discussion ("such an implementation"
referring to the handling of partial writes):

Josh Triplett: So, in theory, _xcb_out_send returned some of the information necessary to do such an implementation, except that it guaranteed a full write so it would never actually return anything interesting about partial writes?
Josh Triplett: And thus you removed the out parameter in favor of that guarantee?
Jamey Sharp: I think if we wanted an implementation like that we'd have thrown out _xcb_out_send entirely. I think it was just leaking implementation details of _xcb_conn_wait out through an abstraction layer.

So, now that I understand this patch more clearly:

Acked-by: Josh Triplett <josh at joshtriplett.org>

- Josh Triplett

More information about the Xcb mailing list