[Xcb] [PATCH 11/19] Xephyr: use xcb for event handling

Julien Cristau jcristau at debian.org
Wed Oct 20 12:46:11 PDT 2010


On Wed, Oct 20, 2010 at 10:50:17 -0700, Ian Osgood wrote:

> 
> On Oct 20, 2010, at 10:11 AM, Julien Cristau wrote:
> 
> > +      switch (xev->response_type)
> 
> I think you want "switch (xev->response_type & 0x7f)" to mask off the client event flag. There is a macro for that in one of the utility headers.
> 
Good catch, thanks.  Amended that patch.

> 
> In some of the other patches I saw references to "xlib" in some
> comments.  You probably want to grep for obsolete terminology like
> that.
> 
Removed those in
http://cgit.freedesktop.org/~jcristau/xserver/commit/?h=xephyr-xcb&id=08fe03226c3b5dcd3794755fa12b4aed398158e0

Cheers,
Julien


More information about the Xcb mailing list