[Xcb] [PATCH 1/2] Remove useless gotsockname

Barton C Massey bart at cs.pdx.edu
Thu Sep 2 23:52:22 PDT 2010


I think maybe Arnaud duplicated some old code of ours that
we have since patched.  I'd suggest looking at these patches
to help figure out what to do.

I think the commits you want are
  06f623500b9d42a0ee15a7dd1383d06e4458bafe
and
  010e566126625c56bdf9989085bacf731520ff87

Of course, that code may also be wrong.  But it's at least
more picked over. :-)

	Bart

In message <87lj7kfm5v.fsf at keller.adm.naquadah.org> you wrote:
> On Thu, Sep 02 2010, Julien Danjou wrote:=20
> 
> > On Thu, Sep 02 2010, Julien Danjou wrote:   I just saw that
> >patch are wrong actually, ignore them.
> 
> Actually, when I say they are wrong, I rather mean that they fix
> the leak Vincent reported, but I don't think they are equivalent
> to what Arnaud wanted to write in the first place.
> 
> But I barely understand what the code wants to do and the porting
> issue it is trying to resolve. So if anyone can write a better
> patch set, correct mines or enlighten me, I'd be glad. Arnaud?


More information about the Xcb mailing list