[Xcb] [PATCH libxcb/libX11 0/3] Avoid excessive reads + automake fixes

Jamey Sharp jamey at minilop.net
Tue Apr 12 14:37:52 PDT 2011

[CC'ing Gaetan for autofoo expertise, and the xcb list for the usual

On Fri, Apr 8, 2011 at 6:22 AM, Rami Ylimäki <rami.ylimaki at vincit.fi> wrote:
> I corrected the patches as you requested some time ago. However, these
> haven't been pushed to the repository yet. Is it OK for you if I do a pull
> request for these patches? I'm asking because in some email you said that
> you'd like to integrate these patches along with the deadlock fixes, but now
> it seems that the deadlock fixes still need to be reworked. However, these
> patches should be independent of the deadlock fixes so I think these could
> nevertheless be applied to the repositories.

Right, right, sorry. I've pushed your libxcb patch, so at least that
will be in the 1.8 release, whenever that happens.

I'm perfectly happy with the corresponding libX11 patch too, except that
I can't merge a patch that depends on new libxcb features until there's
a libxcb release for it to depend on.

In order to merge the reduced-syscall patch to libX11 ASAP, would you
make one more revision to it? If you can add the right autoconf test to
check whether libxcb provides xcb_poll_for_queued_event, and make libX11
fall back to xcb_poll_for_event otherwise, I think that patch would be
safe to merge immediately.

On the other hand, Josh and I aren't yet convinced by your last patch.
Is it really correct to drop the dependency from libX11-xcb on libX11?
The two libraries must agree on the structure definition in Xxcbint.h,
or Bad Things happen. I'm not sure even the current dependency is saving
us here, but removing it doesn't seem better.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20110412/7d9e5282/attachment.pgp>

More information about the Xcb mailing list