[Xcb] [Bug 34037] New: xcb_str_next uses padding when there isn't any

Jamey Sharp jamey at minilop.net
Wed Aug 24 09:20:40 PDT 2011


On Wed, Aug 24, 2011 at 12:57:00PM +0200, Uli Schlachter wrote:
> I took a quick look at this issue. The result is the attached commit. Hopefully
> the commit message explains it all.

Sheesh. I go to sleep, and when I wake up you and Peter have finished a
review round and fixed this long-standing critical bug. :-) Nice work,
guys!

I just pushed one addition: the ALIGNOF macro didn't need to be in the
generated header files, so I moved it to the .c files instead.

Hmmm. We can delete the _sizeof functions for reply structures, right?
We only need them for things you might iterate over, as far as I can
tell, and we don't provide iterators over lists of replies, because the
protocol doesn't do that...

Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20110824/6943e4ae/attachment.pgp>


More information about the Xcb mailing list