[Xcb] [PATCH 2/2] glx: Add protocol for GLX_ARB_create_context and GLX_ARB_create_context_profile

Peter Harris git at peter.is-a-geek.org
Fri Dec 2 09:08:05 PST 2011


On Fri, Dec 2, 2011 at 11:56 AM, Ian Romanick wrote:
> On 11/30/2011 02:22 PM, Peter Harris wrote:
>>
>> There is no implicit padding between lists of the same type. This needs
>> something like<list type="void" name="alignment_pad">  (see
>> xf86vidmode.xml) between the strings.
>>
>> I apologize for the awkward syntax. Unfortunately, we don't have<pad
>> align="4" />  yet.
>
>
> Is this actually necessary?  Looking at the code generated, it looks like
> character lists are automatically padded to 4-bit alignment:

You are correct.

I thought that was changed by commit aa02096b8e7f9 , but apparently it
only changed the default padding for structs.

> If possible, I'd really rather not clutter the protocol spec with the
> alignment_pad mess that xf86vidmode.xml uses.  That bit of padding is almost
> as big as all the rest of the protocol spec.

I agree. Let's leave the explicit padding out for now.

Peter Harris


More information about the Xcb mailing list