[Xcb] libxcb on interix (and/or platforms without getaddrinfo())

Markus Duft mduft at gentoo.org
Wed Jun 8 01:01:02 PDT 2011

On 06/07/11 17:50, Josh Triplett wrote:
> On Tue, Jun 07, 2011 at 04:02:52PM +0200, Markus Duft wrote:
>> I (again) did some porting to interix, this quite exotic POSIX layer on top of the Windows NT kernel. Attached is a small patch i need to get libxcb to build/work. Could you please review it, and comment on it (and possibly just apply it? :) ).
> The patch seems to have broken indentation in several places.  Also,
> please wrap the ifdef around the IPV6 block as well, rather than
> assuming that AF_INET6 will not exist.

Ok, i fixed some, hope it's ok now :) also i realized that (according to linux and interix man pages), arpa/inet.h is required for hton* macros/functions, thus i included them to get rid of some warnings. is this ok for all platforms?

i also fixed a warning in the new code, restructured it a little to match the original better, and got the ifdefs right now :)

> The duplication of some of the setup code, such as the setsockopt calls,
> bugs me a bit, but I don't see an easy way to fix it.  (Tempted to
> suggest using gethostbyname to provide a getaddrinfo function, but that
> seems like overkill.)

i could use a macro for this... i attached a version of the patch with this macro, please review.

Thanks for taking the time!

> - Josh Triplett
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libxcb-1.7-interix.patch
Type: text/x-patch
Size: 2879 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20110608/c856c734/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libxcb-1.7-interix-macro.patch
Type: text/x-patch
Size: 3512 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20110608/c856c734/attachment-0001.bin>

More information about the Xcb mailing list