[Xcb] Bug#629691: libxcb build fails with "nocheck" in DEB_BUILD_OPTIONS

[Steve McIntyre]

Package: libxcb1
Version: 1.7-2
Severity: normal
Tags: patch

Hi,

I'm currently working on cross-building bits of Debian and libxcb
fails to build. This is because of the "nocheck" support in
debian/rules - I can see how it's meant to work, but it fails:

...
make[1]: Leaving directory `/work/stemci01/linaro/armhf/libxcb'
   debian/rules override_dh_auto_test
make[1]: Entering directory `/work/stemci01/linaro/armhf/libxcb'
dh check
dh: Unknown sequence check (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
make[1]: *** [check] Error 9
make[1]: Leaving directory `/work/stemci01/linaro/armhf/libxcb'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
debuild: fatal error at line 1335:
dpkg-buildpackage -rfakeroot -d -us -uc -aarmhf -b -tc failed

The "check" rule has been added to over-ride dh usage, but it looks
like make is too clever and recognises that it's an empty rule,
ignoring it. There's a trivial fix:

--- debian/rules~       2011-06-08 15:47:08.562935012 +0100
+++ debian/rules        2011-06-08 15:47:12.702944319 +0100
@@ -25,6 +25,8 @@
 check:
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
        $(MAKE) -C $(DEB_BUILDDIR) check
+else
+       @echo "nocheck set, not running tests"
 endif

and that works for me.

Cheers,
-- 
Steve McIntyre
steve.mcintyre at linaro.org