[Xcb] Split up of xcb/util repository finally pushed

Uli Schlachter psychon at znc.in
Sun Mar 6 10:21:37 PST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 06.03.2011 12:17, Arnaud Fontaine wrote:
> util-wm
> =======
> 
> [...]I also merged  all the code
> for EWMH which  has already been reviewed on this  mailing list. [...]

I took a closer at the new EWMH functions in util-wm and this surely does look
interesting. However, one thing made me wonder:

_NET_WM_ICON is an array of possible icons, that means it can contain more than
one icon. But all the xcb_ewmh_*_wm_icon* functions assume that it only contains
a single icon.

Also, xcb_ewmh_get_wm_icon_from_reply() only checks if the property value has at
least a length of 2. It doesn't check if this property really is large enough
for the icon that it claims to contain.

Cheers,
Uli

- -- 
"Do you know that books smell like nutmeg or some spice from a foreign land?"
                                                  -- Faber in Fahrenheit 451
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBCAAGBQJNc9CvAAoJECLkKOvLj8sGlLsIALpaokhIzRGqdyXeWlAw5t6Y
T6F9LxZKVYm7eyGMgMjWQOt6oS23kWdGQB3pbm4qMRgBPRcTmbjmdpdUvrHTJObk
RafwE9/76Liw/2EBaM1+95Xplp5aneCfsKQpo3uOk6zDCijmKy5c92olQtfoqbVh
rlH6M9RapgeuRRCEV3gZE5Wmjt+dcGLnDz7GKKfs3imDSjSqxm21lDhimt0yHRw6
oeBa1LEqvwRMhqr38KorI9tXyThypkjSC9UQQJXIE6q8BQBbZRNYP0/Rp7WP5CJj
UXRcHs+lT3fXuFHJ7PMmwbG7N4tUINlAyRmyYO5tHvEQban2BwuWSYC9iXuo/UY=
=3zFm
-----END PGP SIGNATURE-----


More information about the Xcb mailing list