[Xcb] Split up of xcb/util repository finally pushed

Arnaud Fontaine arnaud at andesi.org
Mon Mar 7 06:28:15 PST 2011


Hi,

    > I  took a  closer at the  new EWMH  functions in util-wm  and this
    > surely does look interesting. However, one thing made me wonder:

    >  _NET_WM_ICON is an  array of  possible icons,  that means  it can
    >  contain  more than  one  icon.  But  all the  xcb_ewmh_*_wm_icon*
    > functions assume that it only contains a single icon.

Indeed, besides  of xcb_ewmh_get_wm_icon_from_reply() issue  you mention
below, the other  functions are alright because they  take a pointer and
let the caller prepare the data beforehand.

    >  Also,   xcb_ewmh_get_wm_icon_from_reply()  only  checks   if  the
    > property  value has at  least a length  of 2. It doesn't  check if
    > this property  really is large enough for the  icon that it claims
    > to contain.

Fixed and pushed, thanks for pointing that out.

Cheers,
--
Arnaud Fontaine


More information about the Xcb mailing list