[Xcb] [PATCH] Add support for fence sync objects

[Julien Cristau]

On Mon, May  9, 2011 at 22:53:13 -0700, James Jones wrote:

> -Add XML to define the fence sync objects and operations
>  added in XSync version 3.1.
> 
> -Bump sync module version to 3.1
> 
> Signed-off-by: James Jones <jajones at nvidia.com>
> ---
>  src/sync.xml |   35 ++++++++++++++++++++++++++++++++++-
>  1 files changed, 34 insertions(+), 1 deletions(-)
> 
> diff --git a/src/sync.xml b/src/sync.xml
> index e309233..c4942c3 100644
> --- a/src/sync.xml
> +++ b/src/sync.xml
> @@ -5,7 +5,7 @@ All Rights Reserved.  See the file COPYING in this directory
>  for licensing information.
>  -->
>  <xcb header="sync" extension-xname="SYNC" extension-name="Sync"
> -    major-version="3" minor-version="0">
> +    major-version="3" minor-version="1">
>    <import>xproto</import>
>  
>    <xidtype name="ALARM" />
> @@ -18,6 +18,8 @@ for licensing information.
>  
>    <xidtype name="COUNTER" />
>  
> +  <xidtype name="FENCE" />
> +
>    <enum name="TESTTYPE">
>      <item name="PositiveTransition" />
>      <item name="NegativeTransition" />
> @@ -173,6 +175,37 @@ for licensing information.
>      </reply>
>    </request>
>  
> +  <request name="CreateFence" opcode="14">
> +    <field type="DRAWABLE" name="drawable" />
> +    <field type="FENCE" name="id" />
> +    <field type="BOOL" name="initially_triggered" />
> +  </request>
> +

Kind of nitpicking, but this one uses name="id" for the fence and the
requests below use name="fence".  Maybe it'd be better to be consistent?

> +  <request name="TriggerFence" opcode="15">
> +    <field type="FENCE" name="fence" />
> +  </request>
> +
> +  <request name="ResetFence" opcode="16">
> +    <field type="FENCE" name="fence" />
> +  </request>
> +
> +  <request name="DestroyFence" opcode="17">
> +    <field type="FENCE" name="fence" />
> +  </request>
> +
> +  <request name="QueryFence" opcode="18">
> +    <field type="FENCE" name="fence" />
> +    <reply>
> +      <pad bytes="1" />
> +      <field type="BOOL" name="triggered" />
> +      <pad bytes="23" />
> +    </reply>
> +  </request>
> +
> +  <request name="AwaitFence" opcode="19">
> +    <list type="FENCE" name="fence_list" />
> +  </request>
> +
>    <event name="CounterNotify" number="0">
>      <field type="CARD8" name="kind" />
>      <field type="COUNTER" name="counter" />

In any case,
Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien