[Xcb] xcb/proto portion of [PULL v3] XResource extension v1.2

Alan Coopersmith alan.coopersmith at oracle.com
Mon Apr 23 18:46:59 PDT 2012

On 04/18/12 05:29 AM, Erkki Seppala wrote:
> xcb/proto:
> The following changes since commit b02b7f8dcf92f2b0e7c1edc91f48d2e388d4b8c3:
>   Michael Stapelberg (1):
>         xproto: add doc tags, xcbgen: handle doc tags
> are available in the git repository at:
>   git://gitorious.org/erkkise/fdo-xcb-proto.git client-tracking-v3
> Erkki Seppälä (1):
>       Prototype for XRes v1.2
>  src/res.xml |   70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 69 insertions(+), 1 deletions(-)

I'd be happier to pull this if it had a reviewed-by tag from someone
with a bit of xcb knowledge (which is why I've cc'ed the xcb mailing list).

One thing I note is the comment before "QueryClientIds" says v2.0 where
it presumably should be v1.2.

I'm also unsure about the <struct name="ClientIdValue"> definition,
where the XResproto.h header says:
   CARD32  length B32;
   // followed by length CARD32s

the res.xml has CARD8's instead of CARD32's:
        <field type="CARD32" name="length" />
        <list type="CARD8" name="client_ids">

CARD8 seems too short for a pid_t, but perhaps I'm misunderstanding the
xcb type handling?

	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc

More information about the Xcb mailing list