[Xcb] [Bug 45776] all X programs hanging in libxcb on GNU/kFreeBSD

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45776

--- Comment #9 from Josh Triplett <josh at freedesktop.org> 2012-02-08 13:37:53 PST ---
(In reply to comment #8)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > I looked up the description of MSG_WAITALL in the recv manpage:
> > [...]
> > > This seems entirely wrong for these calls to recv.  Passing MSG_WAITALL
> > > suggests that we don't want the OS to return until it has filled the entire
> > > input buffer, whereas we clearly want the OS to return as soon as it has an X
> > > response for us. 
> > 
> > That's only true for _xcb_in_read() (which I totally missed, whoops).
> > read_block() would loop until it has read as much data as was asked for anyway.
> > 
> well yes, but as you say read_block() does the looping itself anyway, so the
> MSG_WAITALL, while not as broken as in _xcb_in_read, is also useless.

It doesn't do any harm, though, and it allows the OS to do the waiting for us
rather than looping every time we get a bit of data.  Unless it causes
problems, I'd suggest leaving it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.