[Xcb] [PATCH 0/7] xpyb patches

Alex Plotnick shrike at netaxs.com
Wed Feb 29 08:59:50 PST 2012


The following set of patches addresses several issues in xpyb. The first
is a correctness issue, the second and third are crash bugs, the fourth
and fifth are trivial cleanups, and the last two avoid two serious
memory leaks (previously discussed on this mailing list in the July 2011
thread with subject "Xpyb memory leak").

I've tested these fairly extensively, but there may still be issues
remaining. Feedback, suggestions, questions, and commits are all welcome.

Thanks.

Alex Plotnick (7):
  Only use the low-order 7 bits of the type code in determining event
    types.
  Ensure that there's still a valid connection to the X server before  
      attempting to send a request.
  Don't blindly access the connection object in xpybCookie_dealloc;    
    it may be NULL.
  Removed prototype for obsolete xpybReply_populate routine.
  Removed unused data field from xpybProtobj.
  Don't leak reply data.
  Avoid reference cycles in response instances.

 src/cookie.c     |   13 +++++++++-
 src/event.c      |    2 +-
 src/ext.c        |    4 +++
 src/protobj.c    |    1 -
 src/protobj.h    |    1 -
 src/py_client.py |   67 ++++++++++++++++++++++++++++-------------------------
 src/reply.h      |    2 -
 7 files changed, 51 insertions(+), 39 deletions(-)

-- 
1.7.6



More information about the Xcb mailing list