[Xcb] [PATCH 2/2] Expression may only have 'parents' attribute rather than 'parent'.

[Tolga Dalman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 01/25/12 09:07, Arnaud Fontaine wrote:
> From: Arnaud Fontaine <arnau at debian.org>
> 
> --- src/py_client.py |    2 +- 1 files changed, 1 insertions(+), 1
> deletions(-)
> 
> diff --git a/src/py_client.py b/src/py_client.py index ac8099b..68fb254
> 100755 --- a/src/py_client.py +++ b/src/py_client.py @@ -261,7 +261,7 @@
> def _py_get_length_field(expr): ''' if expr.lenfield_name != None: # This
> would be nicer if Request had an is_request attribute... -        if
> hasattr(expr.parent.parent, "opcode"): +        if hasattr(expr.parent,
> 'parent') and hasattr(expr.parent.parent, "opcode"):

Just a minor nit: both strings should have the same style (IMHO). Looks good
otherwise, though I'm not too familiar with this code.

> return expr.lenfield_name else: return 'self.%s' % expr.lenfield_name

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPIGH6AAoJEATLYSm2cxP9oHEH/3dlmg3Qc7uE+92gp9MxrfPr
jpL/lhzI90cjgEr6OZJNEp+WUAl1B9DJKNstx/Vq00qbcBH0wfIJ5dnrBkRM84Iz
xwee35PCUU+IzeiKOEWXlgeK9VZvl93F6KYnUJlZxg3DY9jYVyrn82gBk8L7xVI1
ZnIyAsvvDaxc0iTUDKXb97r10Bu/oilizdK6BqD4eUySMXOfDskEdY7kykvCCf3E
K4XZLf7Kv37gxWy8PJMSnkGP/9HNF7srRTAlcn4HIbAubeKjGlRb4aP+9tV0/0iD
HC9qSvfENaag/Vj1xCHIenc9hKDxzkQnoKy8flPBSy0jOBsQ+1F6xf1OSVRFBCY=
=FIfQ
-----END PGP SIGNATURE-----