[Xcb] [Patch] Fix busy-loop on BSD

Jeremy Huddleston jeremyhu at apple.com
Thu Mar 8 09:08:06 PST 2012


On Mar 8, 2012, at 1:12 AM, Uli Schlachter <psychon at znc.in> wrote:

> On 07.03.2012 21:47, Julien Cristau wrote:
>> On Thu, Mar  1, 2012 at 15:29:03 -0800, Josh Triplett wrote:
>> 
>>> This makes much more sense now.  I had assumed that on a non-blocking
>>> socket, MSG_WAITALL would wait for the full amount of data, rather than
>>> returning with none and producing a busywait.  Given that, removing both
>>> instances of MSG_WAITALL seems correct.
>>> 
>> So now that everybody seems to agree on the patch, can we get this
>> applied and released?
> 
> Nope, Jeremy Huddleston decided otherwise. So here is a new version which fixes
> that conflict and reverts his commit.
> 
> But I agree that this could be pushed.

Ack, sorry.  I missed all that conversation and thought that I was seeing a darwin-specific issue with the buffer not filling.


More information about the Xcb mailing list