[Xcb] xcb-proto-1.7 broke existing xcbgen API

[Uli Schlachter]

On 08.03.2012 18:45, Jeremy Huddleston wrote:
> Ping.  Any thoughts on "the right way" to handle this?

Not really. I'll say something anyway.

> On Mar 3, 2012, at 9:55 PM, Jeremy Huddleston <jeremyhu at freedesktop.org> wrote:
> 
>> Back in late 2010(1), someone reported that xpyb failed to build with recent xcb-proto changes.  It seems this regression in xcb-proto was never addressed and unfortunately xcb-proto-1.7 shipped.
>>
>> I bisected the issue to 76ca2c0b1 which changed xcbgen's API from using "parent" to using "parents".  The patch actually made two completely unrelated changes simultaneously; in the future, please remember to keep one change per patch.
>>
>> So how should this be addressed?  
>>  1) We revert the entire thing and then push just the spec changes

Now that this change is out there, I don't think we can pretend that it isn't.
So I don't like this option.

>>  2) We just "flag day" this and move on, changing xpyb.
>>  3) We support both "parent" and "parents" for maximum compatability?

This seems to be the best option, but it requires someone to actually write the
needed patch. Since you already did so, I think we should use this approach.

>> For 3)
>> From 140262f2291d09863e23fc587bb0034f5bddf571 Mon Sep 17 00:00:00 2001
>> From: Jeremy Huddleston <jeremyhu at apple.com>
>> Date: Sat, 3 Mar 2012 21:53:59 -0800
>> Subject: [PATCH] xcbgen: Address API incompatability between xcb-proto-1.6
>> and xcb-proto-1.7
>>
>> Regression From: 76ca2c0b1527541be59c344118c538ba055ad9d8
>>
>> Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
>> ---
>> xcbgen/xtypes.py |    9 +++++++++
>> 1 file changed, 9 insertions(+)
[...]

Since I don't know python and thus don't know much about these scripts, I can't
say anything about the patch (except for: Wow, quite a small patch).

I'd just propose that you push this change if it fixes the problem and no one
complains. Does anyone object? :-)

Uli

-- 
A learning experience is one of those things that say,
'You know that thing you just did? Don't do that.'
                     -- Douglas Adams