[Xcb] [PATCH] autogen.sh: verify that git submodules are initialized

Uli Schlachter psychon at znc.in
Fri Oct 26 12:28:04 PDT 2012


Hi,

On 26.10.2012 21:14, Michael Stapelberg wrote:
> Unfortunately there was no feedback at all on my patch and I don’t quite
> know why that is. Does anyone care to elaborate? :-)

Urgh. Magic with shell scripts and weird git commands which no one uses
regularly. :-)

> I’ve attached an updated version which fixes a small typing error ("git
> submodule" instead of "git submodules").

> +	# If git is not in PATH, this will not return 0, thus not keeping us
> +	# from building. Since the message is worthless when git is not
> +	# installed, this is what we want.
> +	git submodule status | grep -q '^-'

Still, this would cause a "git not found"-message. So how about at least
redirecting stderr to /dev/null? Alternatively, what's a portable replacement
for "which git"?

Cheers,
Uli
-- 
If you have to type the letters "A-E-S" into your source code, you're doing it
wrong.


More information about the Xcb mailing list