[Xcb] [PATCH] autogen.sh: verify that git submodules are initialized

Michael Stapelberg michael+xcb at stapelberg.de
Fri Oct 26 13:00:24 PDT 2012


Hi Josh, Uli,

Josh Triplett <josh at joshtriplett.org> writes:
> The existence of .gitmodules does not guarantee a git checkout; a
> tarred-up source tree or a snapshot from gitweb or git archive could
> contain that file.  You might try [ -d .git ] && [ -r .gitmodules ], or
> similar.
Good point, I changed that.

Uli, I also added the 2>/dev/null to silence errors when git is not
installed (which seems very weird, but better safe than sorry).

The new version of the patch is attached.

BTW, since Uli asked, here is the error message which autotools spits
out: http://sprunge.us/ABZG

-- 
Best regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-autogen.sh-verify-that-git-submodules-are-initialize.patch
Type: text/x-diff
Size: 1129 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20121026/1eeed728/attachment.patch>


More information about the Xcb mailing list