[Xcb] [PATCH] Build xcb-xkb by default

[Ran Benita]

On Mon, Aug 05, 2013 at 10:17:46PM +0200, Michael Stapelberg wrote:
> Hi,
> 
> I am going to commit this tomorrow evening unless somebody objects
> (also, Signed-Off-Bys welcome):

Yes, please. The useful parts are tested and working well (with the
patches on the list and in master. I'll resend mine now with one extra
patch for convenience). The other parts, well no one's using
them so they can be fixed later.

The only gripe I have is that we need to have calls like this:

    xcb_xkb_get_map_map_unpack(xcb_xkb_get_map_map(reply),
                               reply->nTypes,
                               reply->nKeySyms,
                               reply->nKeyActions,
                               reply->totalActions,
                               reply->totalKeyBehaviors,
                               reply->virtualMods,
                               reply->totalKeyExplicit,
                               reply->totalModMapKeys,
                               reply->totalVModMapKeys,
                               reply->present,
                               &map);

    (also xcb_xkb_get_names_value_list_unpack())

Why do we need to do this manually? And anyway, surely this thing can
just accept the reply directly instead all those error-prone parameters?
But I don't think that's worth changing now, since that might break some
people's code.

It'll be great to have a release once this gets in :)

Ran

> 
> Subject: [PATCH] Build xcb-xkb by default
> 
> There have not been any big issues with xcb-xkb recently.
> 
> Also, Wayland is using xcb-xkb actively, making distributions compile
> libxcb with xkb support anyway, so let’s reflect reality :).
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7364383..8cc5775 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -192,7 +192,7 @@ XCB_EXTENSION(XFixes, "yes")
>  XCB_EXTENSION(XFree86-DRI, "yes")
>  XCB_EXTENSION(Xinerama, "yes")
>  XCB_EXTENSION(XInput, "no")
> -XCB_EXTENSION(XKB, "no")
> +XCB_EXTENSION(XKB, "yes")
>  XCB_EXTENSION(Xprint, "yes")
>  XCB_EXTENSION(SELinux, "no")
>  XCB_EXTENSION(XTest, "yes")
> 
> 
> -- 
> Best regards,
> Michael